Conversation
Comprehensive example values file with inline comments explaining each field, accepted values, and required markers. Covers both production (external Postgres with mTLS, pinned images) and development (bundled dependencies, latest images) scenarios.
When bundledPostgres.enabled is true, the chart now auto-creates the fulfillment-db Secret and postgres-client-cert-service Certificate, eliminating the manual secret creation steps for dev/test deployments using the bundled postgres chart.
|
Warning Review limit reached
More reviews will be available in 4 minutes and 1 second. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository: osac-project/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@eliorerz: This pull request references OSAC-1085 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eliorerz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
Summary
bundledPostgres.enabled: true, the chart auto-creates thefulfillment-dbSecret andpostgres-client-cert-servicecert-manager Certificate, eliminating ~40 lines of manual shell commands from the deployment guide (Phase 2, section 2.2)bundledPostgres.enabled(default:false) — production deployments with external databases are unaffectedFiles
charts/osac/templates/bundled-postgres.yamlbundledPostgres.enabledcharts/osac/values.yamlbundledPostgressection (default disabled)charts/osac/values.schema.jsonbundledPostgrescharts/osac/values-example.yamlcharts/osac/ci/bundled-postgres-values.yamldocs/helm-deployment-guide.mdTest plan
helm lint charts/osac/passesdefault,full,no-aap,bundled-postgres)fulfillment-dbSecret andpostgres-client-serviceCertificate render whenbundledPostgres.enabled: truebundledPostgres.enabled: falsepython3 -m json.tool charts/osac/values.schema.json)